enhanced .findByIdForUser

abarnhard · Aug 26, 2014 · 88ac357 · 88ac357
1 parent 86e3ec2
commit 88ac357
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/app/models/goal.js b/app/models/goal.js
@@ -24,13 +24,7 @@ Goal.findAllByUserId = function(id, cb){
 
 Goal.findByIdForUser = function(goalId, userId, cb){
   goalId = Mongo.ObjectID(goalId);
-  Goal.collection.findOne({_id:goalId}, function(err, goal){
-    if(goal.userId.toString() === userId.toString()){
-      cb(err, goal);
-    }else{
-      cb('ERROR:INVALID USER ID', null);
-    }
-  });
+  Goal.collection.findOne({_id:goalId, userId:userId}, cb);
 };
 
 module.exports = Goal;