Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not run with more recent versions of dependencies #60

Closed
kebarr opened this issue Aug 30, 2019 · 3 comments
Closed

Does not run with more recent versions of dependencies #60

kebarr opened this issue Aug 30, 2019 · 3 comments

Comments

@kebarr
Copy link

kebarr commented Aug 30, 2019

I have tried to run the test code from the README with the example dataset and get an error (TypeError: must be real number, not list) on the line:

iris_dabest.mean_diff.plot(), and occurs due to this line in the gapped_lines function:

--> 162 quantiles = data.groupby(x)[y].quantile([0.25, 0.75])
163 .unstack()
164 .reindex(index=group_order)

I am using Python3.7 with the following modules:

scipy 1.3.0
seaborn 0.9.0
pandas 0.25.0
numpy 1.17.0
matplotlib 3.1.1

which I notice are more recent versions of the dependencies. I installed dabest using pip. I have also built the cloned version to test and get the same error.

I have forked a copy of the code to see if there is a simple fix.

@kebarr kebarr closed this as completed Aug 30, 2019
@josesho
Copy link
Member

josesho commented Aug 30, 2019

Thanks for this notice; I do need to track if dabest plays well with the latest update to numpy and matplotlib. Did you close this because this has been resolved?

@kebarr
Copy link
Author

kebarr commented Aug 30, 2019

I closed it because I found a similar issue during later debugging, and the resolution for that worked here- using pandas 0.24. I have not changed any of the other dependencies so so far it works with later versions of NumPy and matplotlib.

@josesho
Copy link
Member

josesho commented Dec 26, 2019

Closed with #89

@josesho josesho closed this as completed Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants