Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex rrules and frules #41

Open
CheukHinHoJerry opened this issue Jun 4, 2023 · 6 comments
Open

Complex rrules and frules #41

CheukHinHoJerry opened this issue Jun 4, 2023 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@CheukHinHoJerry
Copy link
Collaborator

Currently the rrule of ScalarPoly4MLBasis is only implemented for real inputs. We should generalize it to Complex later.
@cortner
Copy link
Member

cortner commented Jun 4, 2023

I agree. Can you please remove the rrule tests for all complex models, including also the complex spherical and solid harmonics

@CheukHinHoJerry
Copy link
Collaborator Author

CheukHinHoJerry commented Jun 4, 2023 •
edited
Loading

Sure. I will push an update later tmr after doing that and make sure the CI test passes. Most of the issue that you mentioned in the PR is already fixed.

I am working on the symmetrisation layer at the same time with RepLieGroups.

@cortner cortner changed the title rrule of ScalarPoly4MLBasis Complex rrules and frules Jun 6, 2023
@cortner
Copy link
Member

cortner commented Jun 6, 2023

save for CYlm and CRlm??

@CheukHinHoJerry
Copy link
Collaborator Author

CheukHinHoJerry commented Jun 6, 2023 •
edited
Loading

save for CYlm and CRlm??

I will look into it today but I am not sure when I can fix that. Shall we merge the branch first and do that with a small PR later if I can't fix that early enough?

@cortner
Copy link
Member

cortner commented Jun 6, 2023

No rush - let's merge first

@cortner
Copy link
Member

cortner commented Jul 27, 2023

I believe this is still open. At some point it would be good if somebody tests this and starts fixing it.

@cortner cortner added the help wanted Extra attention is needed label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cortner @CheukHinHoJerry