Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtomicOrbitals don't follow Lux rules #86

Open
cortner opened this issue Jun 7, 2024 · 0 comments
Open

AtomicOrbitals don't follow Lux rules #86

cortner opened this issue Jun 7, 2024 · 0 comments

Comments

@cortner
Copy link
Member

cortner commented Jun 7, 2024

Lux layers (and also ours) must be immutable. This rule is not followed in the atomicorbitalsradials implementation. What is currently done doesn't look immediately dangerous so this is not a huge rush to fix. But for the sake of consistency of code style we should discuss whether or how to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant