Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden_irreps with different number of channels for each degree #36

Closed
chaitjo opened this issue Oct 30, 2022 · 1 comment
Closed

hidden_irreps with different number of channels for each degree #36

chaitjo opened this issue Oct 30, 2022 · 1 comment

Comments

@chaitjo
Copy link
Contributor

chaitjo commented Oct 30, 2022

Hi @ilyes319 and co., thank you for the amazing work and clean codebase!

I have been playing around with MACE and seem to encounter an issue when setting the hidden_irreps to not have the same number of channels for each degree (l). E.g. I cannot set hidden_irreps to o3.Irreps("128x0e + 64x1o + 32x2e"). On the other hand, setting the same number of channels for each degree works well. E.g. o3.Irreps("128x0e + 128x1o + 128x2e") is okay, as the README recommends.

Is this expected behaviour?

@ilyes319
Copy link
Contributor

Hey @chaitjo, happy to read you are trying the #code!

This is currently the expected behaviour but it is far from ideal, I agree. A fix to the function reshape_irreps would probably solve it (each term would still need to be a multiple of the other as you have done).

class reshape_irreps(torch.nn.Module):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants