Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel Overflow Error Fixed #27

Merged
merged 7 commits into from Oct 15, 2022
Merged

Pixel Overflow Error Fixed #27

merged 7 commits into from Oct 15, 2022

Conversation

Arsh-78
Copy link
Contributor

@Arsh-78 Arsh-78 commented Oct 11, 2022

  • Decreased height of the Container for Skip button which removes renderflex wihtout changing the view significantly
  • Alternavite Solution could be wrapping the Column with SingleChildScrollable but this cuts some portion of Next Button
  • before :
    error
  • After :
    final save

@Arsh-78 Arsh-78 closed this Oct 11, 2022
@Arsh-78 Arsh-78 reopened this Oct 11, 2022
@Arsh-78 Arsh-78 changed the base branch from master to UI October 11, 2022 13:33
@Arsh-78 Arsh-78 changed the title Arsh 78 Pixel Overflow Error Fixed Oct 11, 2022
Shubhi-Paul
Shubhi-Paul requested changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@Shubhi-Paul Shubhi-Paul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing height from 0.5 to 0.45 will only work for specific devices not all.

use expandable wherever needed

@Arsh-78
Copy link
Contributor Author

Arsh-78 commented Oct 12, 2022 •
edited

@Shubhi-Paul Applied the requested Changes
result:
result2
result22

@Arsh-78
Copy link
Contributor Author

Arsh-78 commented Oct 13, 2022

@Shubhi-Paul @Him-anshuSharma Hey I have added the requested change please let me know if some more edits are needed

@Him-anshuSharma Him-anshuSharma merged commit a4ab87c into ACM-VIT:UI Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubhi-Paul Shubhi-Paul Awaiting requested review from Shubhi-Paul

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Arsh-78 @Shubhi-Paul @Him-anshuSharma @SwaroopSambhayya