Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added repositories screen dark mode #39

Merged
merged 1 commit into from Oct 4, 2021
Merged

added repositories screen dark mode #39

merged 1 commit into from Oct 4, 2021

Conversation

V9vek
Copy link
Contributor

@V9vek V9vek commented Oct 4, 2021

Hey @gaganmalvi 馃憢馃徏
I saw issue #26 regarding dark mode to be implemented in the Repositories Screen when we apply dark mode in our device as a whole
I saw the code of the person assigned to it, but he directly applied the dark mode colors, which will result in Repositories Screen always in dark mode and does not change to light mode when we switch mode of the system

So, I proposing the code for the desired thing that you guys want
Take a look and review the code by checking it on your device

Thanks

@V9vek
Copy link
Contributor Author

V9vek commented Oct 4, 2021

repositories_ui_enhancement2.mp4

repositories_enhancement

Check out the sample video for the desired changes I made

If you want any changes regarding colors or something, do let me know 鈽猴笍
I have added 1 more screen with different colors, if second png colors are fine do let me know too

@gaganmalvi gaganmalvi merged commit bc7fb79 into ACM-VIT:main Oct 4, 2021
@gaganmalvi
Copy link
Member

Lgtm, great work! :))
Will merge, happy Hacktoberfest!
PS. What phone are you using? xD

@V9vek
Copy link
Contributor Author

V9vek commented Oct 4, 2021

Thanks for the merge 鈽猴笍
I am using emulator Pixel 4 API 30

@gaganmalvi
Copy link
Member

I thought you were testing on real hardware 馃槅

@V9vek
Copy link
Contributor Author

V9vek commented Oct 4, 2021

I tested on the real device too but didn't record that
If you need any changes regarding colors or something do let me know

Thanks and please add the required tags for hacktober-fest 鈽猴笍

@gaganmalvi
Copy link
Member

Oh I forgot, it's done now. Thanks for the contribution, and happy Hacktoberfest!
Do check out our Forktober Discord for some cool stuff :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants