Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest only a maximum of three suggestions for any sequence in the dropdown suggestion list. #51

Closed
Avinaash7 opened this issue Oct 5, 2021 · 7 comments · Fixed by #56
Closed

Suggest only a maximum of three suggestions for any sequence in the dropdown suggestion list. #51

Avinaash7 opened this issue Oct 5, 2021 · 7 comments · Fixed by #56
Assignees
@rooparsh
Labels
enhancement New feature or request hacktoberfest

Comments

@Avinaash7
Copy link
Member

21-10-05-20-09-05.mp4

Displaying all the usernames spoils the UI of the app, make sure to suggest only a maximum of 3 usernames.

Note :-

  1. The Database can store many usernames, but if more than 3 usernames typed have the same first two letters then store only the recent 3 usernames of that sequence.
@acmbot
Copy link

acmbot bot commented Oct 5, 2021

Thanks @Avinaash7, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

@acmbot
Copy link

acmbot bot commented Oct 5, 2021

This issue has been approved by the owner and is open to solve!
@Avinaash7 got 5 points for this issue! 🎉

@Avinaash7 Avinaash7 added the enhancement New feature or request label Oct 5, 2021
@rooparsh
Copy link
Contributor

rooparsh commented Oct 5, 2021

@Avinaash7 assign this to me. Will look into it.

@Avinaash7
Copy link
Member Author

@Avinaash7 assign this to me. Will look into it.

Sure! Good Luck

@rooparsh rooparsh mentioned this issue Oct 6, 2021
Merged
@rooparsh
Copy link
Contributor

rooparsh commented Oct 6, 2021

@Avinaash7 issue addressed in PR Link. Review and merge it.

@Avinaash7
Copy link
Member Author

@Avinaash7 issue addressed in PR Link. Review and merge it.

App keeps crashing
Check and correct your code, Good luck!!

@rishuyadav rishuyadav linked a pull request Oct 7, 2021 that will close this issue
Fix : Issue 51 #56
Merged
@acmbot
Copy link

acmbot bot commented Oct 7, 2021

Thanks for closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rooparsh rooparsh

Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix : Issue 51 rooparsh/gitpositive
2 participants
@rooparsh @Avinaash7