Clean code architecture

[rooparsh]

I feel that the project should have a proper architecture and filing system. It's becoming quite tedious and growing out of scope to manage resources.

[acmbot]

Thanks @rooparsh, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

[rooparsh]

If seems ok, assign this issue to me. Will cleanup and rearchitect.

[gaganmalvi]

Sure, will assign.

[acmbot]

This issue has been approved by the owner and is open to solve!
@rooparsh got 5 points for this issue! 🎉

[DarthBenro008]

@rooparsh thanks for taking this up! Do kindly post your ideas to rearchitect the app here and run by the Idea before opening an Pull Request/Getting started to work on it. We might split the issues into smaller issues if required depending upon your proposal

[rooparsh]

Hi @DarthBenro008 , if you see currently the project is not properly structured, contributors are creating files in main package itself without any hierarchy and not following any coding guidelines. This in turn is causing confusion about what and where a particular piece of code is.

My proposal is to properly package the modules functionality wise, keep common utils separate and adhere to strict coding guidelines.

I plan to achieve this in sub parts; in first PR, I have targeted proper packaging and modularity. Then I will focus on revamping coding guidelines and then finally removing deprecated stuff.

[DarthBenro008]

That's great to hear! But could you share what are these "strict coding guidelines" (which guideline to be exact?) and what kind of project structure are you willing to follow? Could you please draw a small architecture diagram on which "module" pertains to which functionality? This would be really great for future contributors to understand the codebase and have a proper architecture of the codebase.

TL;DR: Could you document the architecture pattern that you would be implementing?

[rooparsh]

@DarthBenro008 For architecture :

Guidelines : https://developer.android.com/kotlin/style-guide

[rooparsh]

@DarthBenro008 @gaganmalvi Any update on this issue PR ?

[rooparsh]

Closing issue since Pr is merged here Link

[acmbot]

Thanks for closing this issue!