Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sort functionality #22

Merged
merged 1 commit into from Oct 12, 2021
Merged

Conversation

IgorChernyshov
Copy link
Contributor

Hi,

I've added sort functionality to the project which resolves issue 1 (#1)

P.S. I'd appreciate if you put the hacktoberfest-accepted label to my PR to count it towards the Hacktoberfest goal.

@acmbot
Copy link

acmbot bot commented Oct 11, 2021

Thanks @IgorChernyshov, for opening the pull request! 🙌
One of our team-mates will review the pull request soon. ✅

Copy link
Collaborator

@Samridh29 Samridh29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgorChernyshov could please provide options for the sort feature instead of just reversing the list? Like sorting by date added and lexicographically. Thanks.
Ps - do not change variable names without prior discussion

@IgorChernyshov
Copy link
Contributor Author

IgorChernyshov commented Oct 11, 2021 via email

@Samridh29
Copy link
Collaborator

Sure, will do :) This will require to add additional fields to CoreData model, so I do it too Igor Chernyshov Sent from iPhone Monday, 11 October 2021, 19:21 +0300 from @.*** @.>: @. requested changes on this pull request. @.*** could please provide options for the sort feature instead of just reversing the list? Like sorting by date added and lexicographically. Thanks.

Sure go ahead!

@IgorChernyshov
Copy link
Contributor Author

  • Added a context menu to sort button which allows to sort by name/title/date created.
  • Added date created property to core data model to use it for sorting.
  • Reversed categoryArray property name change, sorry.

@Samridh29 Samridh29 self-requested a review October 12, 2021 13:53
Copy link
Collaborator

@Samridh29 Samridh29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants