New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Sort functionality #22
Conversation
Thanks @IgorChernyshov, for opening the pull request! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IgorChernyshov could please provide options for the sort feature instead of just reversing the list? Like sorting by date added and lexicographically. Thanks.
Ps - do not change variable names without prior discussion
Sure, will do :) This will require to add additional fields to CoreData model, so I do it too
Igor Chernyshov Sent from iPhone
Monday, 11 October 2021, 19:21 +0300 from ***@***.*** ***@***.***>:
***@***.*** requested changes on this pull request.
***@***.*** could please provide options for the sort feature instead of just reversing the list? Like sorting by date added and lexicographically. Thanks.
…—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub , or unsubscribe .
Triage notifications on the go with GitHub Mobile for iOS or Android .
|
Sure go ahead! |
3b630ef
to
90cf68a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Hi,
I've added sort functionality to the project which resolves issue 1 (#1)
P.S. I'd appreciate if you put the hacktoberfest-accepted label to my PR to count it towards the Hacktoberfest goal.