Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White color filter should be added to expandable action icons #47

Closed
afollestad opened this issue Feb 2, 2015 · 5 comments
Closed

White color filter should be added to expandable action icons #47

afollestad opened this issue Feb 2, 2015 · 5 comments

Comments

@afollestad
Copy link
Contributor

This is a notification from an OTA beta testing system in one of my apps. There should be a little download icon next to the "Download" text, but it's a black icon. AcDisplay should add a white color filter to expandable action icons when the black background is enabled in order to make it visible.

rsz_screenshot_2015-02-01-23-04-19

@AChep
Copy link
Owner

AChep commented Feb 21, 2015

Yeah, but forcing white color may break colorful action icons (which are really bad)...

@afollestad
Copy link
Contributor Author

Well, they shouldn't ever be colorful. They're by the design guidelines supposed to be white on Jellybean/KitKat, and black on Lollipop (based on the background color of the notification itself). @AChep

@afollestad
Copy link
Contributor Author

Same with the actual app icons, they should always be white, since the status bar is always a dark color.

@AChep
Copy link
Owner

AChep commented Feb 24, 2015

Has been implemented by a91a1d3

@AChep AChep closed this as completed Feb 24, 2015
@afollestad
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants