fix: increase the mapbox popup width #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiRik
changed the title
serge1peshcoff
pushed a commit
that referenced
this pull request
Mar 9, 2024
## [1.35.11](1.35.10...1.35.11) (2024-03-09) ### Bug Fixes * increase the mapbox popup width ([#2077](#2077)) ([b1b9d44](b1b9d44))
|
🎉 This PR is included in version 1.35.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual width of the popup in the event map is only 80px, not enough to display the name of certain cities in one line and super inadequate for the city description.
My proposal is to change the CSS from
width: 80pxtomax-width: 500pxfor desktop andmax-width 250pxfor mobile. This can keep a small popup with smaller content as just the city name but expand for larger content. However this not completly fix the usability of the popup. For this reason I fixed the maximum height of the popop to 280px (calculated from the mobile map height) and added scrollable text in case of long text content.As-is:
After the patch (mobile):
After the path (desktop):
