Skip to content

Commit

Permalink
feat: add logo to navbar (#280)
Browse files Browse the repository at this point in the history
* feat: add logo to navbar

* chore: fix code style
  • Loading branch information
LeonVreling committed Mar 27, 2020
1 parent 4743a47 commit a9d93cd
Show file tree
Hide file tree
Showing 2 changed files with 780 additions and 1 deletion.
13 changes: 12 additions & 1 deletion src/components/layout/Navbar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<a class="navbar-item is-hidden-tablet" @click="toggleSidebar({opened: !sidebar.opened})">
<font-awesome-icon icon="bars" aria-hidden="true" v-show="!sidebar.hidden" />
</a>
<!-- AEGEE logo would be here -->
<a href="/" class="logo">
<img src="../../images/AEGEE_logo.svg" class="image">
</a>
<a role="button" class="navbar-burger burger" @click="toggleNavbarMenu({opened: !navbar.menuOpened})">
<span aria-hidden="true">
<font-awesome-icon icon="user" />
Expand Down Expand Up @@ -73,6 +75,15 @@ export default {
margin: auto 10px;
}
/* for the logo in the navbar */
.logo {
.image {
height: 52px;
padding: 3px;
padding-left: 10px;
}
}
.navbar-burger {
span {
height: 0;
Expand Down
Loading

3 comments on commit a9d93cd

@dilyanpalauzov
Copy link
Contributor

@dilyanpalauzov dilyanpalauzov commented on a9d93cd Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/images/AEGEE_logo.svg contains:

<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" width="2047px" height="1177px" viewBox="0 0 2047 1177" enable-background="new 0 0 2047 1177" xml:space="preserve">  <image id="image0" width="2047" height="1177" x="0" y="0"
     xlink:href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAB/8AAA…`

so it is in fact a base64-bloated PNG, wrapped in SVG, as evident from xlink:href="data:image/png;base64,iVB… Please extract the PNG data to a PNG file, compress it over zopflipng -m and use it instead of the SVG file in the navbar.

@serge1peshcoff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeonVreling can you check the comment above?

@dilyanpalauzov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to #289.

Please sign in to comment.