New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make force-distance segments integer-valued (unit8 or less) #15

Closed

paulmueller opened this issue Jul 7, 2021 · 1 comment

Member

paulmueller commented Jul 7, 2021 •

edited

Loading

Because this would make things more consistent with other imaging modalities.

Does that break the .tab file format loader? (Yes, needed to adjust parser)
Does that break the .hdf5 file format loader? (No, data were stored as integer anyway)
Does it break nanite? (Yes, in several places where segment was used for indexing)
Does it break nanite rating? (Yes, kind of, workaround was to map "approach" and "retract" to integers to be backwards-compatible)
Does it break PyJibe? (Not really)

This was referenced Jul 7, 2021

Optimize segment handling #16

Closed

support fitting creep-compliance data AFM-analysis/nanite#11

Open

Member Author

paulmueller commented Aug 2, 2021

This leads to a breaking change, since nanite uses the "semgent" column for array indexing.

paulmueller closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment