This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Restore iOS 4.0 compatibility #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zachary Waldowski <zwaldowski@gmail.com>
|
Thanks so much for adding this in. Yeah, I hadn't realized that the class swizzling method I originally was only introduced in 4.3. Cheers! |
|
Thanks for the fix @zwaldowski |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the use of imp_implementationWithBlock (available on iOS 4.3 and up) and replaces it with a similar method using Objective-C Associated Objects (available on iOS 4.0 and up). The swizzling adds/replaces a method that looks up an associated value for the selector on the current class. This is super-safe (not spectacularly safe; safe for the superclass chain).
EDIT: This affects/closes issue #320.