New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand key ID references in commit messages #253

Closed

ktdreyer opened this issue Jun 7, 2022 · 1 comment

ktdreyer commented Jun 7, 2022

https://evil32.com/ explains why we should reduce the use of 32-bit key IDs.

git-crypt writes commit messages with short key IDs:

// given a key fingerprint, return the last 8 nibbles
std::string gpg_shorten_fingerprint (const std::string& fingerprint)
{
	return fingerprint.size() == 40 ? fingerprint.substr(32) : fingerprint;
}

Could we write the full fingerprints instead?

AGWA closed this as completed in

08dbdcf

Owner

AGWA commented Jun 7, 2022

Good idea.

To be clear, git-crypt already uses exclusively full fingerprints internally. The commit message was the only place short IDs were being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment