Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize .netrc #25

Open
SevereOverfl0w opened this issue Mar 15, 2019 · 3 comments
Open

Utilize .netrc #25

SevereOverfl0w opened this issue Mar 15, 2019 · 3 comments

Comments

@SevereOverfl0w
Copy link

I'm not sure if this is possible, but rhubarb works by using the .netrc file in the home directory.

This means no environment variables need setting, and also means I can configure both plugins the same way.

@AGhost-7
Copy link
Owner

Would you be interested in opening a PR for this?

@SevereOverfl0w
Copy link
Author

Absolutely. You have a couple of options for how to do this though:

  1. Forced netrc: Get rid of GH_USER and GH_PASS altogether. This would force error handling down the pipeline to the place where curl is called. This is nice because there's less paths of code to combine.
  2. Hybrid, support both. If GH_USER/GH_PASS is set, use it, else pass --netrc to curl. Downside of this is removing the current error checking in the plugin, as you can't know which approach the user intends.

@AGhost-7
Copy link
Owner

I'm not a fan of making a breaking change. Do you think we could put it behind a flag like with the oauth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants