Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #287

Merged
merged 18 commits into from
Jun 16, 2024
Merged

refactor #287

merged 18 commits into from
Jun 16, 2024

Conversation

rpreen
Copy link
Contributor

@rpreen rpreen commented Jun 12, 2024

Bunch of cleaning and minor refactoring.

Runs CI pylint over the whole aisdc package instead of just attacks and safemodel.

Improves PEP 8 compliance and standardises naming as much as possible, e.g. X_train, X_val, X_test. y_train, y_val, y_test.

Adds a bunch of missing type hints.

Enables more linting rules in Ruff pre-commit.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (cb1ab69) to head (61bc1b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   99.30%   99.34%   +0.04%     
==========================================
  Files          41       40       -1     
  Lines        5301     5224      -77     
==========================================
- Hits         5264     5190      -74     
+ Misses         37       34       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpreen rpreen merged commit 790e17f into main Jun 16, 2024
5 checks passed
@rpreen rpreen deleted the clean_up branch June 16, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant