TypeError: __init__() missing 1 required positional argument: 'action_dim'

[haisheng666]

If you run your own example, errors will be reported. Please help us to find out what the problem is?

/opt/anaconda3/envs/elegant_RL/bin/python /home/lhs/PycharmProjects/elegant_RL/tutorial_BipedalWalker-v3.py
WARNING: env.action_space.high [1. 1. 1. 1.]
env_args = {
'env_num': 1,
'env_name': 'BipedalWalker-v3',
'max_step': 1600,
'state_dim': 24,
'action_dim': 4,
'if_discrete': False,
'target_return': 300,
}
| Arguments Remove cwd: ./BipedalWalker-v3_PPO_0
Traceback (most recent call last):
File "/home/lhs/PycharmProjects/elegant_RL/tutorial_BipedalWalker-v3.py", line 32, in
train_and_evaluate(args)
File "/opt/anaconda3/envs/elegant_RL/lib/python3.8/site-packages/elegantrl/train/run.py", line 87, in train_and_evaluate
agent = init_agent(args, gpu_id, env)
File "/opt/anaconda3/envs/elegant_RL/lib/python3.8/site-packages/elegantrl/train/run.py", line 16, in init_agent
agent = args.agent_class(args.net_dim, args.state_dim, args.action_dim, gpu_id=gpu_id, args=args)
File "/opt/anaconda3/envs/elegant_RL/lib/python3.8/site-packages/elegantrl/agents/AgentPPO.py", line 38, in init
AgentBase.init(self, net_dim, state_dim, action_dim, gpu_id, args)
File "/opt/anaconda3/envs/elegant_RL/lib/python3.8/site-packages/elegantrl/agents/AgentBase.py", line 53, in init
self.act = act_class(net_dim, state_dim, action_dim).to(self.device)
TypeError: init() missing 1 required positional argument: 'action_dim'

[Yonv1943]

The code in net.py is

ElegantRL/elegantrl/agents/net.py

Line 381 in f0f518e

def __init__(self, mid_dim: int, num_layer: int, state_dim: int, action_dim: int):

The code in AgentBase.py is

ElegantRL/elegantrl/agents/AgentBase.py

Line 53 in f0f518e

self.act = act_class(net_dim, state_dim, action_dim).to(self.device)

The code in AgentBase.py should be:

        self.act = act_class(net_dim, num_layers, state_dim, action_dim).to(self.device)
        self.cri = cri_class(net_dim, num_layers, state_dim, action_dim).to(self.device) \

I will upload a Pullrequest 237 to fix this bug. Thank you.

[Praying]

same question, please fix it and merge to master as soon as possible

[JonathanLehner]

self.act = act_class(net_dim, state_dim, action_dim).to(self.device)
self.cri = cri_class(net_dim, state_dim, action_dim).to(self.device)
if cri_class else self.act

this is still in the latest code. It still crashes for me

[JonathanLehner]

easy to reproduce by running the sample notebook https://github.com/AI4Finance-Foundation/FinRL/blob/master/tutorials/3-Practical/FinRL_MultiCrypto_Trading.ipynb