Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the AgentBase.__init__ () for all the DRL algorithms in folder /elegantrl/agents #242

Open
Yonv1943 opened this issue Dec 15, 2022 · 1 comment
Open

Fix the AgentBase.__init__ () for all the DRL algorithms in folder /elegantrl/agents #242

Yonv1943 opened this issue Dec 15, 2022 · 1 comment
Labels
refactoring Code refactoring

Comments

@Yonv1943
Copy link
Collaborator 

    In the commit we still have

self.act = act_class(net_dim, state_dim, action_dim).to(self.device)
self.cri = cri_class(net_dim, state_dim, action_dim).to(self.device)
if cri_class else self.act
the example still crashes for me

Originally posted by @JonathanLehner in #239 (comment)
@YangletLiu YangletLiu added the refactoring Code refactoring label Dec 16, 2022
This was referenced Jan 8, 2023
Open
Merged
@Yonv1943
Copy link
Collaborator Author

Yonv1943 commented Jan 9, 2023 •
edited

The follow Pull request fix this bug ↓
Fix bug for vec env and agentbase init #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YangletLiu @Yonv1943