Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Clean up hard-coded paths #4

Closed
jiaqima opened this issue Nov 2, 2022 · 0 comments · Fixed by #10
Closed

[FEATURE REQUEST] Clean up hard-coded paths #4

jiaqima opened this issue Nov 2, 2022 · 0 comments · Fixed by #10
Assignees
@eshika

Comments

@jiaqima
Copy link
Collaborator

jiaqima commented Nov 2, 2022 •
edited

There are some hard-coded paths such as ./openxai/ML_Models/Saved_Models/ANN/gaussian_lr_0.002_acc_0.91.pt. This is not very friendly to an external API call as one may not be running code at the root of OpenXAI folder.

We should refactor the code to clean up such hard-coded paths.

A good solution might be hosting these files on a Google Drive, which will also reduce the repo size.
@jiaqima jiaqima linked a pull request Nov 22, 2022 that will close this issue
fix mkdir #10
Merged
@jiaqima jiaqima mentioned this issue Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eshika eshika

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix mkdir jiaqima/OpenXAI
2 participants
@jiaqima @eshika