Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment issue with overlay #61

Closed
SahPet opened this issue Feb 26, 2023 · 6 comments
Closed

Alignment issue with overlay #61

SahPet opened this issue Feb 26, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@SahPet
Copy link

SahPet commented Feb 26, 2023

Hi!

There is an alignment issue with the overlay. Using the newest release. Somehow the rendered overlay is unaligned for the bottom 1/4 of the images only - see the discontinuous lines in the images below. I'm predicting on pyramidal tiffs (Philips):

2023-02-26 13_01_22-FastPathology - NEGATIVE_214A4HESHES20210222111056
2023-02-26 13_01_59-FastPathology - NEGATIVE_212A2HESHES20210222110742

@andreped
Copy link
Member

We have observed the same for the cellSens VSI format in this issue #38

However, it is surprising that this is also an issue for the Philips TIFF format. Although this alignment issue maybe looks a little different? For the VSI format the alignment offset is the same for the entire image, whereas for your snapshots it almost seems like some regions have more offset than others. I might be wrong though. For instance, see middle region of bottom image.

Any ideas, @smistad?

@andreped andreped added the bug Something isn't working label Feb 26, 2023
@smistad
Copy link
Member

smistad commented Feb 26, 2023

Strange..., I have not seen this before.
Was this error introduced in the latest release, did it visualize properly before?
Can you share the data/model so i can reproduce it?

@SahPet
Copy link
Author

SahPet commented Feb 26, 2023

Hi Erik! I'm not sure if was there before the update. I can send you the model and an example slide.

@andreped
Copy link
Member

Was this error introduced in the latest release

Note that @SahPet was using one of the latest artifacts, but I believe this was also a problem for the latest release.

Hi Erik! I'm not sure if was there before the update. I can send you the model and an example slide.

@SahPet also send @smistad the corresponding FPL you used for produce this result.

@SahPet
Copy link
Author

SahPet commented Feb 26, 2023

I've sent the model, fpl-file and example tiff on filesender now.

@smistad
Copy link
Member

smistad commented Mar 2, 2023

This error was due to an incorrect calculation of patch positions at the bottom left most patch (and potentially top right most patch). It was fixed in smistad/FAST@dc8eaf7 and will be included in FastPathology in the future. Thanks for reporting this issue.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants