Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy storage broker #1

Closed
Tracked by #9
tumido opened this issue Nov 2, 2021 · 7 comments
Closed
Tracked by #9

Deploy storage broker #1

tumido opened this issue Nov 2, 2021 · 7 comments
Assignees

Comments

@tumido
Copy link
Member

tumido commented Nov 2, 2021

No description provided.

@tumido
Copy link
Member Author

tumido commented Nov 15, 2021

@tumido tumido mentioned this issue Nov 15, 2021
@tumido
Copy link
Member Author

tumido commented Nov 15, 2021

@tumido
Copy link
Member Author

tumido commented Nov 15, 2021

This one is not so easy to untangle: https://github.com/RedHatInsights/insights-storage-broker/blob/master/deploy/clowdapp.yml

I'd like to deploy it without logging to a bucket and without multiple kafka topics at first....

@sesheta
Copy link

sesheta commented Feb 13, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2022
@schwesig
Copy link
Contributor

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 21, 2022
@schwesig schwesig reopened this Feb 21, 2022
@tumido
Copy link
Member Author

tumido commented Mar 4, 2022

/assign @mimotej

@mimotej

as noted above, we need to deploy quay.io/cloudservices/insights-storage-broker into seraph-ingress namespace. You need to convert https://github.com/RedHatInsights/insights-storage-broker/blob/master/deploy/clowdapp.yml into a Deployment resource which inlines config for ingress and platform-mq Kafka via config.json. See:
https://github.com/AICoE/seraph/blob/main/ingress/base/config.json and https://github.com/AICoE/seraph/blob/main/ingress/base/deployment.yaml as an example on how it's done for Ingress service.

Spec for the clowder options can be found here: https://github.com/RedHatInsights/insights-storage-broker/blob/879a1d977af6783281ab229a8fcd97421a1f5e72/src/storage_broker/utils/config.py#L34-L60 using Clowder Python library: https://github.com/RedHatInsights/app-common-python

Consider dependency on platform.upload.validation, platform.upload.available, platform.inventory.events,platform.payload-status, platform.notifications.ingress. Omit platform.upload.buckit, platform.logging.logs topics since we are not using buckit or logging.
Consider insights-dev-upload-perm, insights-dev-upload-rejected buckets only, use the same naming conventions as for the current bucket.
Omit all HABERDASHER variables, we are not using it.

Note: please do not use https://github.com/RedHatInsights/insights-storage-broker/blob/master/templates/deployment.yml, as we want to deploy the config as it is defined in ClowderApp.

Investigate use of S3 credentials in storage broker, since it seems they may be using the same credentials for all buckets - this may be problematic in ODF.

Use: https://github.com/RedHatInsights/insights-storage-broker/blob/879a1d977af6783281ab229a8fcd97421a1f5e72/default_map.yaml#L1-L2 only, we are not validating OpenShift payloads for now.
Checkout #22 for puptoo hints.

@schwesig
Copy link
Contributor

seraph is currently on hold
closing issues to clean up until this will be focussed again
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants