Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Frame API should also provide information on the types of the stored collections #379

Open
tmadlener opened this issue Feb 23, 2023 · 3 comments
Assignees

Comments

@tmadlener
Copy link
Collaborator

Currently the Frame API only gives access to the names of the stored collections. It should also be easily possible to get the corresponding type (string), without having to do

auto coll = frame.get(name);
const auto type = coll->getTypeName();

This can be quite costly, as it potentially triggers the unpacking of a collection, simply to get to its type.

@hegner
Copy link
Collaborator

hegner commented May 15, 2023

making the typename available before unpacking goes rather deep into the stack. The buffers would already need to get that into their interface.

@hegner hegner self-assigned this May 15, 2023
@tmadlener
Copy link
Collaborator Author

With #413 this information would become available from the buffers as string_views, because we need that information internally to retrieve the correct schema evolution function.

@hegner
Copy link
Collaborator

hegner commented May 15, 2023

ah. thanks for the reminder :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants