Conversation
What happens if the input is the empty string? I believe you'll get an error. |
It's not very convenient to type in / using say mobile phone |
@Renha 🤔 This value should probably be something that nobody would ever start a sentence with, either purposefully or accidentally. I could see But personally I agree with @dyc3 that it should be |
else: | ||
console_print("Saving has been turned off. Cannot save.") | ||
else: | ||
console_print(f"Invalid argument: {args[0]}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the minimum Python version required for AIDungeon documented anywhere? f-strings require Python 3.6, which shouldn't conflict with the Colab runtime, but may conflict with users running AIDungeon locally.
I believe tensorflow 1.15 requires Python 3.5 or greater, so this might bump the required Python version up a minor version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, the install script specifically checks for python 3.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, completely missed that. Thanks!
@nickwalton Good catch, will fix. @Renha We have mobile players? Even then, I'm pretty sure during a normal session commands wouldn't be used very often, so convenience shouldn't be a huge factor. |
I'm good with this, after you add it to |
@ben-bay done! |
This makes it so that commands must start with a
/
, and splits the input by spaces to get arguments for commands.My reasoning for choosing
/
specifically is because users (especially gamers) will be more familiar with using/
to denote commands (eg minecraft)