Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can you add the Byte parameter? #30

Closed
hedandan1989 opened this issue Oct 7, 2023 · 5 comments
Closed

Can you add the Byte parameter? #30

hedandan1989 opened this issue Oct 7, 2023 · 5 comments
Assignees
@AJMitev
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v. 4.1

Comments

@hedandan1989
Copy link

hedandan1989 commented Oct 7, 2023 •
edited

In different situations, the file data source may be either stream or bytes, and although it can be converted to each other, the conversion of large files will result in double the memory usage.
@AJMitev
Copy link
Owner

AJMitev commented Oct 10, 2023

I am sorry but I cannot understand your request. Can you please explain your use case and what is the problem you are facing?

@AJMitev AJMitev added the question Further information is requested label Oct 10, 2023
@duynl71
Copy link

duynl71 commented Oct 12, 2023

According to https://en.wikipedia.org/wiki/List_of_file_signatures, the docx/xlsx/zip share the same signature. So I guess @hedandan1989 suggest better behavior for these file types.

@AJMitev
Copy link
Owner

AJMitev commented Oct 12, 2023

And what that behavior would be?

@hedandan1989
Copy link
Author

And what that behavior would be?

Sorry for waiting so long to reply.
I have edited the theme again.

@hedandan1989 hedandan1989 mentioned this issue Oct 18, 2023
Closed
@AJMitev AJMitev self-assigned this Oct 18, 2023
@AJMitev AJMitev added enhancement New feature or request good first issue Good for newcomers and removed question Further information is requested labels Oct 18, 2023
@AJMitev AJMitev added this to the v. 4.1 milestone Oct 18, 2023
@AJMitev
Copy link
Owner

AJMitev commented Oct 18, 2023

Implemented with commit 8632b74

@AJMitev AJMitev closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AJMitev AJMitev

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v. 4.1
Development

No branches or pull requests
3 participants
@AJMitev @hedandan1989 @duynl71