-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : Admin Page #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
메튜 버튼 생성
admin page를 템플릿에 선언하였습니다.
애니메이션 효과와 메뉴 버튼을 제거하였습니다.
반응형을 구현하기 위해 grid를 사용하였습니다. 폰트에도 vmin을 사용했습니다.
Coreight98
added
FE
Front-End Develop
Feat
Create Feature
Fix
Fix Feature
CSS
design
labels
Feb 7, 2022
우선 main pull 받아서 conflict 수정이랑 재사용할수있는거 해주세염 |
jin-Pro
reviewed
Feb 9, 2022
return ( | ||
<AdminContainer> | ||
<Title>{ADMIN_CATEGORY[category]}</Title> | ||
<Button {...SmallLoginButtonType} title={"로그아웃"} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거를 기본 Header에서 수정해야할거같아요!
아직 비즈니스로직 구현이 큰게 없어서 그런지는 모르겠으나, 전반적으로 좋은 것 같아요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ 진행 작업 ]
[ 문제 사항 ]
하지만 hearder style의 몸집이 커진다는 것을 알게 되었습니다.
추후 분리를 할지에 대한 논의가 필요할 거 같습니다.
처음에는 사이드바에 애니메이션을 넣어서 구현하였지만, 버튼을 통한 메뉴 선택을 버리고, 한 눈에 볼 수 있게 변경하였습니다.
추후 page number를 표기하는 부분을 추가할 생각입니다.
[ 해결 방법 ]
atomic 답게 templete을 잘 사용하는 방법이 아직 익숙하지 않은 거 같습니다. atomic을 잘 적용한 프로젝트를 찾아보니, templete에는 데이터만 제공하여 페이지에 그린다는 부분을 이해하여, 구현하고자 했는데, 로고와 검색 버튼의 사진을 temple단에서 넣는 부분이 효율적이지 않다고 생각하여, atom에서 컴포넌트화하여 구현하였습니다.