Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMP Label logic in Konsist and Ktlint #14

Open
wants to merge 2 commits into
base: konsist
Choose a base branch
from
Open

KMP Label logic in Konsist and Ktlint #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49411b2
Revert "feat: remove label logic from Konsist and Ktlint"
AKJAW Oct 27, 2023
aaa2743
fix: Konsist label condition
AKJAW Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/code_review.yml
View file
Open in desktop
Expand Up @@ -47,10 +47,18 @@ jobs:
Konsist:
needs: SetUp
uses: ./.github/workflows/konsist.yml
with:
shouldRunKmp: ${{ needs.SetUp.outputs.shouldRunKmp }}
shouldRunAndroid: ${{ needs.SetUp.outputs.shouldRunAndroid }}
shouldRunDesktop: ${{ needs.SetUp.outputs.shouldRunDesktop }}

Ktlint:
needs: SetUp
uses: ./.github/workflows/ktlint.yml
with:
shouldRunKmp: ${{ needs.SetUp.outputs.shouldRunKmp }}
shouldRunAndroid: ${{ needs.SetUp.outputs.shouldRunAndroid }}
shouldRunDesktop: ${{ needs.SetUp.outputs.shouldRunDesktop }}

Build:
needs: [ SetUp, Konsist, Ktlint ]
Expand Down
17 changes: 16 additions & 1 deletion .github/workflows/konsist.yml
View file
Open in desktop
Expand Up @@ -2,6 +2,16 @@ name: Konsist

on:
workflow_call:
inputs:
shouldRunKmp:
required: true
type: string
shouldRunAndroid:
required: true
type: string
shouldRunDesktop:
required: true
type: string

jobs:
Konsist:
Expand All @@ -13,4 +23,9 @@ jobs:
- name: Job set up
uses: ./.github/actions/job-set-up

- run: ./gradlew :konsist:testDebugUnitTest
- run: |
if ${{ inputs.shouldRunKmp == 'true' || inputs.shouldRunAndroid == 'true' || inputs.shouldRunDesktop == 'true' }}; then
./gradlew :konsist:testDebugUnitTest
else
exit 0
fi
17 changes: 16 additions & 1 deletion .github/workflows/ktlint.yml
View file
Open in desktop
Expand Up @@ -2,6 +2,16 @@ name: Ktlint

on:
workflow_call:
inputs:
shouldRunKmp:
required: true
type: string
shouldRunAndroid:
required: true
type: string
shouldRunDesktop:
required: true
type: string

jobs:
Ktlint:
Expand All @@ -13,4 +23,9 @@ jobs:
- name: Job set up
uses: ./.github/actions/job-set-up

- run: ./gradlew ktlintCheck
- run: |
if ${{ inputs.shouldRunKmp == 'true' || inputs.shouldRunAndroid == 'true' || inputs.shouldRunDesktop == 'true' }}; then
./gradlew ktlintCheck
else
exit 0
fi