G.F.FCAS.TooMuchSpaceAfterComma should allow argument alignment

[white-gecko]

I get following sniff error

239 | ERROR | Expected 1 space after comma in function call; 2 found
| | (Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma)
241 | ERROR | Expected 1 space after comma in function call; 3 found
| | (Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma)
242 | ERROR | Expected 1 space after comma in function call; 2 found
| | (Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma)

for following code

$bnd['top'] = new Erfurt_Sparql_Query2_Smaller('?lat',  $bnd['top']);
$bnd['rgt'] = new Erfurt_Sparql_Query2_Smaller('?long', $bnd['rgt']);
$bnd['btm'] = new Erfurt_Sparql_Query2_Larger('?lat',   $bnd['btm']);
$bnd['lft'] = new Erfurt_Sparql_Query2_Larger('?long',  $bnd['lft']);
$dttyps[]   = new Erfurt_Sparql_Query2_ConditionalAndExpression($bnd);

We only want a check that at least one space exists but argument alignment should be possible

[seebi]

@larseidam can you react on this? it is much work?

[larseidam]

I have used a existing sniff to check for the spacing in funktion calls. I think I can easy deactivate the check for spaces after comma and save it as our own sniff.

[white-gecko]

I think the spaces after comma should not be deactivated, but it should also accept aligned code. Is this possible?

[larseidam]

Now I have uploaded a update of the sniff (50b2754), so you need at least one space after each comma, but you are able to set more to align the code.

Please check it with your code and if you are happy with it, please close the issue!

[seebi]

@white-gecko please test and close ...

[white-gecko]

Yes, I will test it when I'm back home

[white-gecko]

Thanks it works now.