Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add account delete option popup #172

Merged
merged 3 commits into from
Nov 15, 2023
Merged

feat: add account delete option popup #172

merged 3 commits into from
Nov 15, 2023

Conversation

EmilyPPP
Copy link
Collaborator

@EmilyPPP EmilyPPP commented Nov 5, 2023 •
edited
Loading

  • 탈퇴 이유 선택 팝업 추가
  • 회원가입 시 동의 체크박스 리팩토링
  • Dialog 버튼 컴포넌트로 리팩토링

다음 작업

  • 탈퇴 시 이유 서버로 전달

@EmilyPPP EmilyPPP linked an issue Nov 5, 2023 that may be closed by this pull request
[FEAT] 계정 탈퇴 이유 선택 팝업 추가 #171
Open
2 tasks
kongnayeon
kongnayeon approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@kongnayeon kongnayeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

src/screens/myAccount/MyAccount.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 탈퇴 이유 로직 추가하실 때 탈퇴 옵션 선택 관련 로직들은 같이 묶어서 훅으로 작성해도 깔끔할 것 같아요!!

@EmilyPPP EmilyPPP merged commit bfae484 into develop Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongnayeon kongnayeon kongnayeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 계정 탈퇴 이유 선택 팝업 추가
2 participants
@EmilyPPP @kongnayeon