Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accumulators] test binop_with_scalar fails in 32-bit OS #587

Open
wistaria opened this issue Nov 7, 2018 · 2 comments · May be fixed by #609
Open

[accumulators] test binop_with_scalar fails in 32-bit OS #587

wistaria opened this issue Nov 7, 2018 · 2 comments · May be fixed by #609
Assignees
@galexv
Labels
arch Architecture-dependent bugs

Comments

@wistaria
Copy link
Collaborator

wistaria commented Nov 7, 2018 •
edited

In 32-bit OS with sizeof(int) == sizeof(long) == 4, binop_with_scalar fails with the following message: binop_with_scalar.log.
Other 31 tests in accumulators passed successfully.
@wistaria wistaria mentioned this issue Nov 7, 2018
Merged
@egull
Copy link
Collaborator

egull commented Nov 7, 2018

Alex, this is another one for Friday. Accumulators are barely touched since the old ALPS, so this must have been working on 32 bit at some time.

@galexv
Copy link
Collaborator

galexv commented Nov 9, 2018

The test is relatively new (for issue #79). The error is only with float accumulators: discrepancy between vector and scalar float accumulators' behavior.
We saw something similar before: #181 (comment) .
Should we simply increase the tolerances to 1E-3, although this looks too much, or shall we dig further?

@mwallerb mwallerb added the arch Architecture-dependent bugs label Nov 19, 2018
galexv added a commit that referenced this issue Feb 4, 2019
@galexv
Disable support for legacy accumulators of vector<float>
7a2162f 
This is related to issue #587
galexv added a commit that referenced this issue Feb 8, 2019
@galexv
Disabled legacy accumulators of float vectors with explicit message
988f3d6 
...and added a test.

The handling of the situation is still not ideal: if declaring a named
accumulator holding `vector<float>` is attempted, compilation fails
with `static_assert` issuing a relevant message, but other compilation
errors are triggered that add clutter.

However, this should close #587.

Cross-ref: #181 (comment)
@galexv galexv linked a pull request Feb 15, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galexv galexv

Labels
arch Architecture-dependent bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disabled legacy accumulator<vector<float>> ALPSCore/ALPSCore
4 participants
@wistaria @galexv @egull @mwallerb