Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strict settings option in timemory + expanded config syntax #31

Merged
merged 1 commit into from Jun 8, 2022

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Jun 8, 2022

  • timemory settings updates
    • strict config option
    • improved variable support
      • $env: lvalues
      • support for ${VARIABLE} syntax
      • support for variable expansion in substring
    • chained config files

Example configuration file using new syntax

# config variable
$USE                            = ON
$COMP                           = $env:OMNI_COMPONENTS

# exports as default environment variable (new)
$env:OMNI_SAMP                  = ON
$env:OMNI_EXTRA                 = ON
$env:OMNI_ROCM                  = OFF

# now supports ${USE} instead of just $USE (new)
OMNITRACE_USE_PERFETTO          = ${USE}
OMNITRACE_USE_TIMEMORY          = ${USE}

OMNITRACE_USE_SAMPLING          = $env:OMNI_SAMP
OMNITRACE_USE_THREAD_SAMPLING   = $env:OMNI_SAMP

OMNITRACE_USE_KOKKOSP           = $env:OMNI_EXTRA
OMNITRACE_USE_OMPT              = $env:OMNI_EXTRA
OMNITRACE_CRITICAL_TRACE        = $env:OMNI_EXTRA

OMNITRACE_USE_ROCTRACER         = $env:OMNI_ROCM
OMNITRACE_USE_ROCM_SMI          = $env:OMNI_ROCM

# variables are expanded in substring after "=" (new)
OMNITRACE_TIMEMORY_COMPONENTS   = wall_clock ${COMP}

- timemory settings updates
  - strict config option
  - improved variable support
    - $env: lvalues
    - support for ${VARIABLE} syntax
    - support for variable expansion in substring
  - chained config files
@jrmadsen jrmadsen merged commit 3ca81fd into ROCm:main Jun 8, 2022
@jrmadsen jrmadsen deleted the support-strict-settings branch June 8, 2022 21:58
@jrmadsen jrmadsen added the timemory Issue affects/involves timemory features/capabilities label Jun 9, 2022
jrmadsen added a commit that referenced this pull request Jun 14, 2022
- example config file will fail due to PR #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timemory Issue affects/involves timemory features/capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant