Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AMReX and Microphysics submodules of MAESTROeX #91

Closed
harpolea opened this issue Aug 11, 2019 · 2 comments
Closed

Make AMReX and Microphysics submodules of MAESTROeX #91

harpolea opened this issue Aug 11, 2019 · 2 comments

Comments

@harpolea
Copy link
Member

See AMReX-Astro/Castro#651.

This would make the installation process easier for new users.
@pgrete
Copy link

pgrete commented Oct 21, 2019 •
edited
Loading

I was just about to make a suggestion on this during the JOSS review.
In addition to making the installation process easier it also enables to keep the repositories in sync, e.g., making sure that an older version of MAESTROeX is always tied to a version of AMReX that work together.
So +1 from my point of view on this (but this is independent of the review).

@harpolea
Copy link
Member Author

harpolea commented Aug 5, 2020

This has been fixed

@harpolea harpolea closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harpolea @pgrete