Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate cpu/cuda modules #36

Open
casperdcl opened this issue Dec 21, 2023 · 0 comments · May be fixed by #45
Open

separate cpu/cuda modules #36

casperdcl opened this issue Dec 21, 2023 · 0 comments · May be fixed by #45
Assignees
Labels
enhancement New feature or request

Comments

@casperdcl
Copy link
Member

current

  • cuvec.cuvec: at compile time, use cudaMallocManaged/cudaFree if available, otherwise use malloc/free
    • at runtime, people with NVIDIA GPUs are forced to allocate memory on their device

proposed

  • cuvec.cuvec_cpu: uses malloc/free
  • cuvec.cuvec_cuda: if available, use cudaMallocManaged/cudaFree, otherwise ImportError
  • cuvec.cuvec: point to one of the above
@casperdcl casperdcl added the enhancement New feature or request label Dec 21, 2023
@casperdcl casperdcl self-assigned this Dec 21, 2023
@casperdcl casperdcl linked a pull request Mar 13, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant