Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Library panics when the user isn't found #23

Closed
ANF-Studios opened this issue Jan 25, 2021 · 1 comment
Closed

[BUG] Library panics when the user isn't found #23

ANF-Studios opened this issue Jan 25, 2021 · 1 comment
Assignees
@ANF-Studios
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ANF-Studios
Copy link
Member

Describe the bug
When getting a user that isn't found, it throws an exception due to missing properties.

To Reproduce

  1. get a user that you are sure of doesn't exist.
  2. reqwest panics.

Expected behavior
It should not panic.

Screenshots
image

Additional context
A fix for this could be to not execute the GET method at all if the user does not exist or some sort of solution.
@ANF-Studios ANF-Studios added the bug Something isn't working label Jan 25, 2021
@ANF-Studios ANF-Studios self-assigned this Jan 25, 2021
@ANF-Studios ANF-Studios added the good first issue Good for newcomers label Jan 25, 2021
@ANF-Studios
Copy link
Member Author

Fixed with commit master/436648fd275878b1590394057c4e2f10ff5e6a74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ANF-Studios ANF-Studios

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ANF-Studios