Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antsMotionCorr: center of rotation is not written #419

Open
oesteban opened this issue Feb 28, 2017 · 2 comments
Open

antsMotionCorr: center of rotation is not written #419

oesteban opened this issue Feb 28, 2017 · 2 comments

Comments

@oesteban
Copy link

I see that, for some reason, the affine matrices are not written: https://github.com/stnava/ANTs/blob/master/Examples/antsMotionCorr.cxx#L1078

Is there a reason for not writing them?

The problem is that the center of rotation is lost. Even though it is set on the center of masses, computing it with a different software will give slightly different values (also there is the orientation convention issue). This is an example for an image I just used:

python: -3.5478249 , -14.09039795,   0.74709859
ANTs:   3.5478134155273438 14.090387344360352 0.7471063733100891

To make antsMotionCorr reproducible, the FixedParameters of the transform should be written out somewhere. A use case (actually my problem): you want to apply the motion correction but using LanczosWindowedSinc interpolation. This is currently (AFAIK) not possible, since there is no way to feed the transforms into antsApplyTransforms. Am I right on this?

If I submit a PR, will it be considered anytime soon?
Are there any preferences on whether adding a flag to output the itk matrices or just appending the fixed parameters as MoCo parameters in the csv file?

Thanks very much

@oesteban oesteban changed the title antsMotionCorr: center of rotation is now written antsMotionCorr: center of rotation is not written Feb 28, 2017
@satra
Copy link
Collaborator

satra commented Mar 15, 2017

@ntustison - what do you think?

@ntustison
Copy link
Member

@satra sounds good to me if @oesteban wants to submit a PR. I'd look at it but, unfortunately, antsMotionCorr is one piece of ANTs code that I don't think I've ever touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants