Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a primitive that inherits from shapely directly. #5

Closed
Tracked by #4
ANaka opened this issue Feb 27, 2023 · 2 comments
Closed
Tracked by #4

Creating a primitive that inherits from shapely directly. #5

ANaka opened this issue Feb 27, 2023 · 2 comments

Comments

@ANaka
Copy link
Owner

ANaka commented Feb 27, 2023 •
edited
Loading

genpen.Shape was adding new features to shapely.geometry.Polygon via composition, but looking back it feels like inheritance would have been smarter.
@ANaka ANaka mentioned this issue Feb 27, 2023
Open
4 tasks
@ANaka ANaka changed the title Creating a primitive that inherits from shapely directly. genpen.Shape was adding new features to shapely.geometry.Polygon via composition, but looking back it feels like inheritance would have been smarter. Creating a primitive that inherits from shapely directly. Feb 27, 2023
@ANaka
Copy link
Owner Author

ANaka commented Feb 27, 2023

goddammit
shapely/shapely#1698

@ANaka
Copy link
Owner Author

ANaka commented Feb 27, 2023

okay this is very unlikely to be worth it, clearly not intended for inheritance for what look like good reasons

@ANaka ANaka closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ANaka