Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test files missing pixi box on Primary Item #151

Open
joedrago opened this issue May 23, 2021 · 5 comments · May be fixed by #200
Open

Some test files missing pixi box on Primary Item #151

joedrago opened this issue May 23, 2021 · 5 comments · May be fixed by #200
Labels

Comments

@joedrago
Copy link

Related: AOMediaCodec/libavif#635

libavif v0.9.1 has a new strict mode, which verifies that the pixi box is present and valid for the primary item (when decoding items) and, it appears that there are some test file we've offered that fail this check.

I believe this is the list:

Note: I did not check any files that use layer selectors (Apple files, quebec_3layer_op2, etc).

@leo-barnes
Copy link
Collaborator

I checked testFiles/Apple and testFiles/Xiph. All of the AVIF's in there have pixi specified.

@aklemets
Copy link
Contributor

Where does it say that that PixelInformation box is required for Grid Items? Seems meaningless to include it in Grid items since such items don't have any pixels. Is this the result of some recent spec update?

@leo-barnes
Copy link
Collaborator

leo-barnes commented Nov 14, 2022

@aklemets

Where does it say that that PixelInformation box is required for Grid Items? Seems meaningless to include it in Grid items since such items don't have any pixels. Is this the result of some recent spec update?

MIAF:

7.3.6.6 Pixel Information
The pixel information property shall be associated with every image that is displayable (not hidden) and should be associated with all images, and shall be supported by the MIAF renderer. This information shall be output by the MIAF reader as metadata and interpreted by the MIAF renderer.

Arguably I would say it's even more important to have it for the 'grid' item. As a parser, I don't want to have to look into individual tiles to figure out if the image is an 8-bit image or a 10-bit image.

@aklemets
Copy link
Contributor

You are right, but strangely enough the colour information property is optional for derived images. That could be just as important as the pixel information. It seems like an inconsistency in the MIAF spec.

@leo-barnes
Copy link
Collaborator

but strangely enough the colour information property is optional for derived images

It's actually optional for coded images as well, hence why it's not required for derived images. Which is a shame since it has caused a lot of problems. Back when the wording was proposed, we wanted to basically do what JPEG does and say that no extra color information => sRGB.
But JPEG has no way of signaling color info within the bitstream itself, so there is no way for confusion to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants