Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a new name #69

Closed
AObuchow opened this issue Jun 19, 2020 · 6 comments · Fixed by #75
Closed

Come up with a new name #69

AObuchow opened this issue Jun 19, 2020 · 6 comments · Fixed by #75
Labels
documentation Improvements or additions to documentation

Comments

@AObuchow
Copy link
Owner

Although "Modern Dark" works as a name, it might be worth coming up with a better name. On twitter, an Eclipse contributor mentioned that the word "Modern" can quickly get out-of-sync with changes in UI trends.

@PyvesB suggested naming the theme "Eclipse Spectrum Theme" which sounds nice to me.

To quote his reasoning (in the context of the new logo ideas):
"The dark background and the colored lines reminds me of those color spectrum charts used in physics, chemistry and astronomy. Hence my suggestion: "Eclipse Spectrum Theme". :)"

Ideally, if the plugin is going to be renamed, it should occur before the marketplace release. I could always change the name after the 0.0.1 release, but it might confuse some users (I'm not sure how many downloads the plugin will get for the initial marketplace release, so it might not be a big deal)

All name ideas are welcome :)

@AObuchow AObuchow added the documentation Improvements or additions to documentation label Jun 19, 2020
@ingomohr
Copy link
Contributor

I like "Spectrum" too. 👍

@AObuchow
Copy link
Owner Author

So I'm almost decided on using Spectrum as the new name.

However, I was thinking of calling it "Eclipse Spectrum Dark Theme" on marketplace just so people know right away that it's a dark theme. The branding & logo can just say "Spectrum Theme" or "Eclipse Spectrum Theme".

Eventually, I'd like the theme to work both as a light/dark theme but that will probably require some upstream changes to Eclipse. Once this is done, the "dark" component from the name can be entirely removed.

Any thoughts?

@ingomohr
Copy link
Contributor

Sounds reasonable (to include "dark theme" for the marketplace).

And you could name the bundle and feature simply com.aobuchow.themes.spectrum. That way, you could add light-theme support w/o having to change the ID of your bundles/feature.

@AObuchow
Copy link
Owner Author

Awesome thanks for all the feedback & advice @ingomohr :)

I've decided that for the plugin's marketplace release, it will be called Spectrum Theme, and the repo will be renamed to Eclipse-Spectrum-Theme. Thanks for the great suggestion @PyvesB & @cristatus !

@AObuchow
Copy link
Owner Author

This bug can be closed once a PR is merged to rename everything "Modern Dark" related to "Spectrum".

AObuchow added a commit that referenced this issue Jun 23, 2020
Fix #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 23, 2020
Fix #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 23, 2020
Fix #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 23, 2020
Fix #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@AObuchow
Copy link
Owner Author

Currently updating the README.. here are some potentially useful emojis to spice things up hahah:

🔥🤩👀🌘🌈🔥🌑💫✨🌟🎨🌌💾📷🔮🧹📥📊🌀🔆

AObuchow added a commit that referenced this issue Jun 24, 2020
Part of #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 24, 2020
Part of #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 24, 2020
Part of #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 24, 2020
Part of #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 24, 2020
Fix #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 24, 2020
Fix #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit that referenced this issue Jun 24, 2020
Fix #69

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants