Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate operationIds don't cause validation errors #68

Closed
YagoGG opened this issue Jun 25, 2017 · 2 comments
Closed

Duplicate operationIds don't cause validation errors #68

YagoGG opened this issue Jun 25, 2017 · 2 comments

Comments

@YagoGG
Copy link

YagoGG commented Jun 25, 2017

Running SwaggerParser.validate() on a Swagger file with operationId fields that aren't unique doesn't throw any exception.

The Swagger specification indicates that these fields must have unique values:

Unique string used to identify the operation. The id MUST be unique among all operations described in the API. Tools and libraries MAY use the operationId to uniquely identify an operation, therefore, it is recommended to follow common programming naming conventions.

(Emphasis mine)

@JamesMessinger
Copy link
Member

Good suggestion. I'll plan to add that to the validation logic.

@marcelstoer
Copy link
Contributor

I have a fix ready that I can create a PR for once the current issues with master are sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants