New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile to be able to develop in a Container #33
Conversation
This Container is supposed to be used with the VSCode Remote Container extension. It has every required tools ready to be used at the proper location. It copy inside the container all the .apk files that are in the folder where you start the Remote Container extension. You can either attach a running container or build it from the Dockerfile. Signed-off-by: Rémi Lavedrine <remi.lavedrine@outlook.com>
The devcontainer.json file describes everything we want to install in the VSCode development container. Signed-off-by: Rémi Lavedrine <remi.lavedrine@outlook.com>
@Shosta Thanks for the PR. I've looked into code a bit but before commenting on anything I want to ask about the advantage of putting this all in a container, for most other people, apart from isolation. I must say, I haven't used this feature in VS Code yet so I may be missing any other obvious benefits of this approach. This will help me understand the usability side of this PR. For now, it seems to be doing the same thing but with more steps because APKLab will itself download all tools on the first run. And, if this PR is intended to solve the issue you faced in #30, ie. not able to detect tool paths first time, then we should look at fixing the issue directly in APKLab. |
@Surendrajat The point of all of this is to be able to work and pentest the app in a container where I can have all the tools, set up and environment required. That's the purpose of all of it. |
@Shosta Thanks for explaining. It makes sense. Now that I think about it, it means that people will have to clone the entire APKLab repo for these two files which might not be the best option. So here is what I propose(let me know if you have a better alternative/reasoning): |
Good deal. 👌🏼 |
@Shosta Closing this one. |
This Container is supposed to be used with the VSCode Remote Container extension.
➜ It has every required tools ready to be used at the proper location.
➜ It copies inside the container all the .apk files that are in the folder where you start the Remote Container extension.
➜ You can either attach a running container or build it from the Dockerfile.
Add the VSCode devcontainer.json file
➜ The devcontainer.json file describes everything we want to install in the VSCode development container.
Signed-off-by: Rémi Lavedrine
So now,
apktool
,jadx
anduber-apk-signer
are not downloaded and installed somewhere on your machine, but everything stays in the Container and is already downloaded at the proper location within the container.It works like a charm. 👌🏼
I launched it with InsecureBankv2.apk in the folder and everything was decoded perfectly. 👍🏼