Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when two KASV are rendered and one TextInput gets focused #25

Closed
alvaromb opened this issue Jun 1, 2016 · 14 comments
Closed

Crash when two KASV are rendered and one TextInput gets focused #25

alvaromb opened this issue Jun 1, 2016 · 14 comments
Assignees
Labels

Comments

@alvaromb
Copy link
Collaborator

alvaromb commented Jun 1, 2016

No description provided.

@ararog
Copy link

ararog commented Aug 10, 2016

I would say its one of the most important fixes, I'm facing this issue right now.

@pimkle
Copy link

pimkle commented Aug 11, 2016

I'm unsubscribing this issue. Here's how I resolve this. The crash happens randomly, certain pages do every time, some pages never crash. I even removed everything in the page except the InputText, the page still, crashed. So I abandoned this wonderful plugin, and go to an IOS developer for help. Yeah, the keyboard problem only happens on IOS devices, and he recommend me an IOS plugin:IQKeyboardManager-master, and I just simply drag the folder into my Xcode, and the problem was fixed perfectly. If you are not a professional IOS developer, and you don't know how to put the IQKeyboardManager plugin into your project, leave a comment, I may tell you the detail.

@alvaromb
Copy link
Collaborator Author

Hello @ararog @pimkle!

DISCLAIMER
I'm a professional iOS developer and mobile team lead currently in my company 😆

Issue
Now about the issue. I've sent a PR that has been accepted and will be introduced into React Native 0.32 that solves this issue. For more info and context, please read my explanation here facebook/react-native#7876.

In this library you have a branch that, if you use the code of my PR, completely solves the issue (https://github.com/APSL/react-native-keyboard-aware-scroll-view/tree/ancestor_check). I'm waiting the release of React Native to merge & release the ancestor_check branch.

And, in this case, I prefer to provide a JavaScript solution to the keyboard & scroll view problem. Once the fix has landed into the React Native core, I'll be able to dig deep into the Android support and you'll have a component working for both platforms without any other dependencies.

@alvaromb
Copy link
Collaborator Author

The crash do not happen randomly, @pimkle, it does happen when you have two scroll views listening for keyboard events. Please do read my comments in the React Native PR.

@imchathu87
Copy link

any solution for this .. nothing is working here :( :(

@alvaromb
Copy link
Collaborator Author

Hello @empitechathu!

Everything is working here, we're using the component with the patch in all our apps. Please install the library from the ancestor_check branch and apply the changes in the React Native PR. Once my changes land in a RN release, I'll release the ancestor_check branch.

@pimkle
Copy link

pimkle commented Aug 15, 2016

@alvaromb I got that! I'll try it someday. Thanks! 😁

@alvaromb
Copy link
Collaborator Author

Please be patient, the PR should land in React Native 0.32 (or 0.33). In the meantime, you can manually add the code to bypass the issue.

@Swordsman-Inaction
Copy link
Collaborator

@alvaromb 0.32 is released, your PR is in it.

@alvaromb
Copy link
Collaborator Author

Thanks for the info @Swordsman-Inaction!

I'll release a new version of the component today :)

@alvaromb
Copy link
Collaborator Author

I won't have enough time for a release today, haven't tested all the features yet.

Expect a release tomorrow.

Thanks!

@alvaromb
Copy link
Collaborator Author

This is the PR #57

@alvaromb
Copy link
Collaborator Author

@Swordsman-Inaction just FYI, 0.32 isn't released yet, only the RC-0.

@alvaromb
Copy link
Collaborator Author

Merged #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants