Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker is misaligned with camera image #241

Closed
jorgecardoso opened this issue Apr 14, 2021 · 3 comments
Closed

Marker is misaligned with camera image #241

jorgecardoso opened this issue Apr 14, 2021 · 3 comments
Labels
question Further information is requested

Comments

@jorgecardoso
Copy link

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
With versions 3.1.0+, the barcode markers are misaligned with the camera image.

If the current behavior is a bug, please provide the steps to reproduce.

The following demo shows two versions of the same scene, the only change is the AR.js version (3.0.2, and 3.1.0).
The error occurs with all versions above or equal to 3.1.0: the superimposed 3D object is not perfectly aligned with the marker image.

The demo uses a video source, but the issue also happens with the camera image:

https://ar-js-misalignment.glitch.me/

https://glitch.com/edit/#!/ar-js-misalignment

Please mention other relevant information such as the browser version, Operating System and Device Name
Tried on Windows desktop, Chrome and Firefox.

Also verified on Mobile Chrome.

What is the expected behavior?
The superimposed 3D objects should be aligned with the marker image on the camera, as happens with version 3.0.2.

If this is a feature request, what is motivation or use case for changing the behavior?

@jorgecardoso
Copy link
Author

Just found the other issues which may be related: #76 and #242

@kalwalt
Copy link
Member

kalwalt commented Apr 19, 2021

Hi @jorgecardoso if you are using different version of Ar.js you will have different behaviours. Before that PR #60 was merged you need to move the model onto the z axis, with the merged changes you need to move the model onto the y axis as was in the old repository (by jerometeienne). Hope that helps.

@kalwalt kalwalt added the question Further information is requested label Apr 19, 2021
@jorgecardoso
Copy link
Author

Hi @jorgecardoso if you are using different version of Ar.js you will have different behaviours. Before that PR #60 was merged you need to move the model onto the z axis, with the merged changes you need to move the model onto the y axis as was in the old repository (by jerometeienne). Hope that helps.

Thank you! I must have missed that info in the documentation.
It helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants