Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APK size significantly increased due to Pdfium usage #157

Closed
melvin4u445 opened this issue Dec 12, 2021 · 1 comment
Closed

APK size significantly increased due to Pdfium usage #157

melvin4u445 opened this issue Dec 12, 2021 · 1 comment

Comments

@melvin4u445
Copy link
Contributor

Remove pdfium library from the build because it has increased the apk size from 5 MB to 48 MB and according to @CloudLevi there are also other reasons to replace this library.

Related commit ba41cb5

@kirillt kirillt changed the title Replacing PDF preview generation APK size significantly increased due to Pdfium usage Dec 13, 2021
@kirillt kirillt self-assigned this Dec 21, 2021
@kirillt
Copy link
Member

kirillt commented Jul 11, 2022

  1. We have split universal APK into individual APKs by target:
    https://github.com/ARK-Builders/ARK-Navigator/actions/runs/2449022646
    Size reduced to 23MB.

  2. We have implemented PDF previews rendering using Pdfium but in the Rust lib, build size reduced further to 18.5MB:
    https://github.com/ARK-Builders/ARK-Navigator/actions/runs/2645847993

ARK-Builders/arklib-android#8
This PR isn't merged yet due to necessity of performance tuning (PDF previews generation slowed down significantly), but this should be matter of time and this issue isn't actual now anyway.

@kirillt kirillt closed this as completed Jul 11, 2022
@kirillt kirillt removed their assignment Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants