Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit unused samples from RFFT/RIFFT twiddle factor tables #1275

Closed
richardallenatgarmin opened this issue Aug 6, 2021 · 2 comments
Closed
Assignees
Labels
DSP enhancement moved moved to new github repository

Comments

@richardallenatgarmin
Copy link

It's possible to reduce the size of realCoefA, realCoefB, realCoefAQ31, realCoefBQ31, realCoefAQ15,realCoefBQ15 when not using the 8192 point FFT by reducing the twidCoefRModifier values accordingly , which both reduces the data space used and can give a small performance benefit when more densely packing the arrays.

I'd like to suggest that we split the tables in the same way that twiddleCoef_rfft_NFFT has done, but build in only a single, largest used realCoefA_NFFT and adjust twidCoefRModifier accordingly.

In this way, still only a single table will be linked in, but now reflecting the size required for the largest supported FFT, and smaller FFTs can share the largest table in the way they do today.

For my application, this saves around 15kB of Flash since we're only using several small FFTs.

@christophe0606
Copy link
Contributor

@richardallenatgarmin I agree. Those big tables are not good. We have made a big effort with other tables to enable a better control of the code size through lots of compiler defines.
This work must continue with those remaining big tables.

I can't communicate a schedule but at some point it will be done.

@christophe0606
Copy link
Contributor

We are moving CMSIS-DSP to a new repository : https://github.com/ARM-software/CMSIS-DSP

I have recreated the github issues on the new repository (sometimes merging a few related ones). You can see the link just above this comment (... mentioned this issue ...).

So, I am closing the github issue here.

@christophe0606 christophe0606 added the moved moved to new github repository label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSP enhancement moved moved to new github repository
Projects
None yet
Development

No branches or pull requests

3 participants