Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail to build: error: definition of implicit copy constructor for 'PolymorphicAction<testing::internal::ReturnVoidAction>' is deprecated because it has a user-declared copy assignment operator #346

Closed
yurivict opened this issue Jun 20, 2022 · 6 comments

Comments

@yurivict
Copy link

/disk-samsung/freebsd-ports/misc/astc-encoder/work/astc-encoder-3.7/Source/GoogleTest/googlemock/include/gmock/gmock-actions.h:455:3: error: definition of implicit copy constructor for 'PolymorphicAction<testing::internal::ReturnVoidAction>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  GTEST_DISALLOW_ASSIGN_(PolymorphicAction);
  ^
/disk-samsung/freebsd-ports/misc/astc-encoder/work/astc-encoder-3.7/Source/GoogleTest/googletest/include/gtest/internal/gtest-port.h:682:8: note: expanded from macro 'GTEST_DISALLOW_ASSIGN_'
  void operator=(type const &) = delete
       ^

Not sure why you need to rebuild gtest when ready to use package exists.

Version: 3.7
clang-13
FreeBSD 13.1

@solidpixel
Copy link
Contributor

Not sure why you need to rebuild gtest when ready to use package exists.

We build for systems without package managers, so this is the least painful option.

@solidpixel
Copy link
Contributor

I've updated main to use the latest (1.11.0) release of googletest, which should help, but not tried this on clang-13 yet.

@solidpixel
Copy link
Contributor

Testing with the newer versions of Clang, and while the Googletest issue is solved there are still quite a lot of warnings flagged by clang-13. Will put up a separate PR to fix this.

@solidpixel
Copy link
Contributor

PR #348 to fix the compiler warnings flagged by newer builds of Clang.

@solidpixel
Copy link
Contributor

Merged. Let me know if you hit any more issues.

@yurivict
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants