Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (or shrink) the default set of modules loaded #611

Closed
douglas-raillard-arm opened this issue Dec 12, 2022 · 0 comments · Fixed by #634
Closed

Remove (or shrink) the default set of modules loaded #611

douglas-raillard-arm opened this issue Dec 12, 2022 · 0 comments · Fixed by #634

Comments

@douglas-raillard-arm
Copy link
Contributor

douglas-raillard-arm commented Dec 12, 2022

Cgroup module randomly fails to load on pixel 6 for unknown reasons. It seems to be related to how the USB is setup (via a hub or not) but we haven't been able to really understand the issue so far. Since the cgroups module is enabled by default, WA will crash because of unused feature, which is a shame.

LISA is not directly impacted because the approach to loading is different:

  • we don't enable any module by default
  • the modules are loaded on-demand
  • there is a user-provided list of forbidden modules. Users typically don't care about needing module X or Y unless it makes their setup crash. The code already knows what module it needs, so all we need is the list of forbidden module.

Some modules have to be loaded in advance and by the user, but none of the ones in the default list seem to fall in that category:

    default_modules = [
        'hotplug',
        'cpufreq',
        'cpuidle',
        'cgroups',
        'hwmon',
    ]

I haven't looked at the details but it seems that WA could also use a loading-on-demand system, in which case there would be no point in having that default module set anymore.

The WA issue can be currently worked around using:
https://workload-automation.readthedocs.io/en/latest/faq.html?highlight=default_modules#q-i-get-the-error-module-x-failed-to-install-on-target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant