Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError: No module named 'wa_results_collector' #702

Closed
vingu-linaro opened this issue Dec 20, 2018 · 6 comments
Closed

ImportError: No module named 'wa_results_collector' #702

vingu-linaro opened this issue Dec 20, 2018 · 6 comments
Assignees

Comments

@vingu-linaro
Copy link
Contributor

I tried to run sched-evaluation-full.ipynb with next branch but face error:


ImportError Traceback (most recent call last)
in
2 from IPython.display import display
3
----> 4 from wa_results_collector import WaResultsCollector
5 import pandas as pd
6

ImportError: No module named 'wa_results_collector'

@valschneider
Copy link
Contributor

Hi Vincent,

wltests is probably the last block that hasn't been yet updated in lisa/next. It's still on my backlog, but there was an offline chat with @credp && @derkling suggesting that we could restructure it instead.

I merged #692 just today but I now realise I didn't move the wltests notebook into "deprecated". I'll see if I can just get it working instead.

@valschneider valschneider self-assigned this Dec 20, 2018
@vingu-linaro
Copy link
Contributor Author

ok.
Our farm uses a python script based on sched-evaluation-full.ipynb (python2.7) to post process WAv3 results.
IIUC, you don't accept new changes in master branch so my plan was to move next branch and push our script (at least the .ipynb version).

@valschneider
Copy link
Contributor

I see, thanks for thinking about upstreaming it!

I'll have a look and see if I can unblock that shortly.

@valschneider
Copy link
Contributor

So looking into it it seems like wa_results_collector should mostly work, I think the issues I'm hitting are with the notebook code itself.

All imports in lisa/next have to be absolute, so to import wa_results_collector you should do:

from lisa.wa_results_collector import WaResultsCollector

And see how that fares with your script. I'll keep looking at the notebook at my side and fix any issues I find.

@valschneider
Copy link
Contributor

#703 should get things working in next.

@vingu-linaro
Copy link
Contributor Author

Everything works fine with last update in next. I'm going to submit a pull request for adding the notebook that we use for postprocessing WA results in lava job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants