Skip to content
This repository has been archived by the owner on Nov 26, 2021. It is now read-only.

Remove legacy from trappy/__init__.py #233

Closed
bjackman opened this issue Jan 4, 2017 · 3 comments
Closed

Remove legacy from trappy/__init__.py #233

bjackman opened this issue Jan 4, 2017 · 3 comments

Comments

@bjackman
Copy link
Contributor

bjackman commented Jan 4, 2017

There's some code marked "For backwards compatibility. Remove by 2016-12-31" in trappy/__init__.py.

So let's remove it?
@bjackman bjackman mentioned this issue Jan 4, 2017
Merged
@JaviMerino
Copy link
Contributor

#234 is merged, so closing

@bjackman
Copy link
Contributor Author

Cheers. I was under the impression this would auto-close when the PR was merged.

@JaviMerino
Copy link
Contributor

You need to say "fixes" before the issue number: https://github.com/blog/1506-closing-issues-via-pull-requests

I believe there are other magic words. I think I've closed issues with just "fix" or "close" or something like that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JaviMerino @bjackman