Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meet tests-api-analogin bug? #10

Closed
ccli8 opened this issue Nov 15, 2016 · 3 comments
Closed

Meet tests-api-analogin bug? #10

ccli8 opened this issue Nov 15, 2016 · 3 comments

Comments

@ccli8
Copy link

ccli8 commented Nov 15, 2016

SHA
53d4476

Description
I am testing ci-test-shield on NuMaker-PFM-M453 board and meet a potential bug in tests-api-analogin. In TESTS/API/AnalogIn/AnalogIn.cpp > AnalogInput_Test,

    AnalogIn ain(ain_pin);
    BusInOut outputs(dout_pin1,dout_pin2,dout_pin3,dout_pin4,dout_pin5);
    outputs.output();
    int x = 0;
    int y= 0;
    outputs = 1;
    float prev_value = 0;

The outputs bus should initialize to 0:

    AnalogIn ain(ain_pin);
    BusInOut outputs(dout_pin1,dout_pin2,dout_pin3,dout_pin4,dout_pin5);
    outputs.output();
    int x = 0;
    int y= 0;
    outputs = 0;
    float prev_value = 0;
@BlackstoneEngineering
Copy link
Contributor

BlackstoneEngineering commented Nov 15, 2016 •
edited
Loading

Nice find. Fixed here : 6ca1b89

That said, the PFM-M453 board will still fail the analog in test with the followin results

+--------------------------+------------------+--------------------+--------+--------------------+-------------+
| target                   | platform_name    | test suite         | result | elapsed_time (sec) | copy_method |
+--------------------------+------------------+--------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | tests-api-analogin | FAIL   | 16.47              | shell       |
+--------------------------+------------------+--------------------+--------+--------------------+-------------+
mbedgt: test suite results: 1 FAIL
mbedgt: test case report:
+--------------------------+------------------+--------------------+-----------------------+--------+--------+--------+--------------------+
| target                   | platform_name    | test suite         | test case             | passed | failed | result | elapsed_time (sec) |
+--------------------------+------------------+--------------------+-----------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | tests-api-analogin | Analog Input on AIN_0 | 0      | 4      | FAIL   | 0.49               |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | tests-api-analogin | Analog Input on AIN_1 | 0      | 5      | FAIL   | 0.6                |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | tests-api-analogin | Analog Input on AIN_2 | 0      | 5      | FAIL   | 0.59               |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | tests-api-analogin | Analog Input on AIN_3 | 0      | 5      | FAIL   | 0.6                |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | tests-api-analogin | Analog Input on AIN_4 | 0      | 5      | FAIL   | 0.6                |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | tests-api-analogin | Analog Input on AIN_5 | 0      | 5      | FAIL   | 0.59               |
+--------------------------+------------------+--------------------+-----------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 6 FAIL
mbedgt: completed in 21.16 sec
mbedgt: exited with code 1
[mbed] ERROR: "mbedgt" returned error code 1.
[mbed] ERROR: Command "mbedgt --test-spec C:\cygwin\home\ausbla01\mbed\ci-test-shield\BUILD\tests\NUMAKER_PFM_M453\GCC_ARM\test_spec.json -n tests-api-analogin -V" in "C:\cygwin\home\ausbla01\mbed\ci-
test-shield"

If you uncomment the printf's in the code it looks like this:

[1479239861.67][CONN][INF] found KV pair in stream: {{__testcase_start;Analog Input on AIN_0}}, queued...
[1479239861.68][CONN][RXD] X=0
[1479239861.69][CONN][RXD] outputs=0x1
[1479239861.71][CONN][RXD] prevValue=0.000000
[1479239861.72][CONN][RXD] ain=0.000000
[1479239861.72][CONN][RXD]
[1479239861.73][CONN][RXD] X=1
[1479239861.74][CONN][RXD] outputs=0x3
[1479239861.76][CONN][RXD] prevValue=1.000000
[1479239861.77][CONN][RXD] ain=1.000000
[1479239861.77][CONN][RXD]
[1479239861.88][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239861.89][CONN][RXD] X=2
[1479239861.90][CONN][RXD] outputs=0x7
[1479239861.92][CONN][RXD] prevValue=1.000000
[1479239861.93][CONN][RXD] ain=1.000000
[1479239861.93][CONN][RXD]
[1479239862.04][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239862.05][CONN][RXD] X=3
[1479239862.06][CONN][RXD] outputs=0xf
[1479239862.08][CONN][RXD] prevValue=1.000000
[1479239862.09][CONN][RXD] ain=1.000000
[1479239862.09][CONN][RXD]
[1479239862.20][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239862.21][CONN][RXD] X=4
[1479239862.22][CONN][RXD] outputs=0x1f
[1479239862.24][CONN][RXD] prevValue=1.000000
[1479239862.25][CONN][RXD] ain=1.000000
[1479239862.26][CONN][RXD]
[1479239862.37][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239862.41][CONN][INF] found KV pair in stream: {{__testcase_finish;Analog Input on AIN_0;0;4}}, queued...
[1479239862.51][CONN][RXD] >>> 'Analog Input on AIN_0': 0 passed, 4 failed with reason 'Test Cases Failed'
[1479239862.51][CONN][RXD]
[1479239862.56][CONN][RXD] >>> Running case #2: 'Analog Input on AIN_1'...
[1479239862.60][CONN][INF] found KV pair in stream: {{__testcase_start;Analog Input on AIN_1}}, queued...
[1479239862.61][CONN][RXD] X=0
[1479239862.62][CONN][RXD] outputs=0x1
[1479239862.64][CONN][RXD] prevValue=0.000000
[1479239862.65][CONN][RXD] ain=0.000000
[1479239862.65][CONN][RXD]
[1479239862.66][CONN][RXD] X=1
[1479239862.67][CONN][RXD] outputs=0x3
[1479239862.69][CONN][RXD] prevValue=1.000000
[1479239862.70][CONN][RXD] ain=1.000000
[1479239862.70][CONN][RXD]
[1479239862.81][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239862.82][CONN][RXD] X=2
[1479239862.83][CONN][RXD] outputs=0x7
[1479239862.85][CONN][RXD] prevValue=1.000000
[1479239862.86][CONN][RXD] ain=1.000000
[1479239862.86][CONN][RXD]
[1479239862.97][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239862.98][CONN][RXD] X=3
[1479239862.99][CONN][RXD] outputs=0xf
[1479239863.01][CONN][RXD] prevValue=1.000000
[1479239863.02][CONN][RXD] ain=1.000000
[1479239863.02][CONN][RXD]
[1479239863.13][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239863.14][CONN][RXD] X=4
[1479239863.15][CONN][RXD] outputs=0x1f
[1479239863.17][CONN][RXD] prevValue=1.000000
[1479239863.18][CONN][RXD] ain=1.000000
[1479239863.18][CONN][RXD]
[1479239863.29][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239863.34][CONN][INF] found KV pair in stream: {{__testcase_finish;Analog Input on AIN_1;0;4}}, queued...
[1479239863.43][CONN][RXD] >>> 'Analog Input on AIN_1': 0 passed, 4 failed with reason 'Test Cases Failed'
[1479239863.43][CONN][RXD]
[1479239863.48][CONN][RXD] >>> Running case #3: 'Analog Input on AIN_2'...
[1479239863.52][CONN][INF] found KV pair in stream: {{__testcase_start;Analog Input on AIN_2}}, queued...
[1479239863.53][CONN][RXD] X=0
[1479239863.54][CONN][RXD] outputs=0x1
[1479239863.56][CONN][RXD] prevValue=0.000000
[1479239863.57][CONN][RXD] ain=0.000000
[1479239863.57][CONN][RXD]
[1479239863.58][CONN][RXD] X=1
[1479239863.59][CONN][RXD] outputs=0x3
[1479239863.61][CONN][RXD] prevValue=1.000000
[1479239863.62][CONN][RXD] ain=1.000000
[1479239863.62][CONN][RXD]
[1479239863.73][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239863.74][CONN][RXD] X=2
[1479239863.75][CONN][RXD] outputs=0x7
[1479239863.77][CONN][RXD] prevValue=1.000000
[1479239863.78][CONN][RXD] ain=1.000000
[1479239863.78][CONN][RXD]
[1479239863.89][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239863.90][CONN][RXD] X=3
[1479239863.91][CONN][RXD] outputs=0xf
[1479239863.93][CONN][RXD] prevValue=1.000000
[1479239863.94][CONN][RXD] ain=1.000000
[1479239863.94][CONN][RXD]
[1479239864.05][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239864.06][CONN][RXD] X=4
[1479239864.07][CONN][RXD] outputs=0x1f
[1479239864.09][CONN][RXD] prevValue=1.000000
[1479239864.11][CONN][RXD] ain=1.000000
[1479239864.11][CONN][RXD]
[1479239864.22][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239864.27][CONN][INF] found KV pair in stream: {{__testcase_finish;Analog Input on AIN_2;0;4}}, queued...
[1479239864.35][CONN][RXD] >>> 'Analog Input on AIN_2': 0 passed, 4 failed with reason 'Test Cases Failed'
[1479239864.35][CONN][RXD]
[1479239864.40][CONN][RXD] >>> Running case #4: 'Analog Input on AIN_3'...
[1479239864.45][CONN][RXD] X=0
[1479239864.45][CONN][INF] found KV pair in stream: {{__testcase_start;Analog Input on AIN_3}}, queued...
[1479239864.46][CONN][RXD] outputs=0x1
[1479239864.48][CONN][RXD] prevValue=0.000000
[1479239864.50][CONN][RXD] ain=0.000000
[1479239864.50][CONN][RXD]
[1479239864.50][CONN][RXD] X=1
[1479239864.51][CONN][RXD] outputs=0x3
[1479239864.53][CONN][RXD] prevValue=1.000000
[1479239864.55][CONN][RXD] ain=1.000000
[1479239864.55][CONN][RXD]
[1479239864.66][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239864.66][CONN][RXD] X=2
[1479239864.67][CONN][RXD] outputs=0x7
[1479239864.69][CONN][RXD] prevValue=1.000000
[1479239864.71][CONN][RXD] ain=1.000000
[1479239864.71][CONN][RXD]
[1479239864.82][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239864.82][CONN][RXD] X=3
[1479239864.84][CONN][RXD] outputs=0xf
[1479239864.85][CONN][RXD] prevValue=1.000000
[1479239864.87][CONN][RXD] ain=1.000000
[1479239864.87][CONN][RXD]
[1479239864.98][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239864.98][CONN][RXD] X=4
[1479239865.00][CONN][RXD] outputs=0x1f
[1479239865.02][CONN][RXD] prevValue=1.000000
[1479239865.03][CONN][RXD] ain=1.000000
[1479239865.03][CONN][RXD]
[1479239865.14][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239865.19][CONN][INF] found KV pair in stream: {{__testcase_finish;Analog Input on AIN_3;0;4}}, queued...
[1479239865.27][CONN][RXD] >>> 'Analog Input on AIN_3': 0 passed, 4 failed with reason 'Test Cases Failed'
[1479239865.28][CONN][RXD]
[1479239865.33][CONN][RXD] >>> Running case #5: 'Analog Input on AIN_4'...
[1479239865.37][CONN][INF] found KV pair in stream: {{__testcase_start;Analog Input on AIN_4}}, queued...
[1479239865.38][CONN][RXD] X=0
[1479239865.39][CONN][RXD] outputs=0x1
[1479239865.41][CONN][RXD] prevValue=0.000000
[1479239865.42][CONN][RXD] ain=0.000000
[1479239865.42][CONN][RXD]
[1479239865.43][CONN][RXD] X=1
[1479239865.44][CONN][RXD] outputs=0x3
[1479239865.46][CONN][RXD] prevValue=1.000000
[1479239865.47][CONN][RXD] ain=1.000000
[1479239865.47][CONN][RXD]
[1479239865.58][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239865.59][CONN][RXD] X=2
[1479239865.60][CONN][RXD] outputs=0x7
[1479239865.62][CONN][RXD] prevValue=1.000000
[1479239865.63][CONN][RXD] ain=1.000000
[1479239865.63][CONN][RXD]
[1479239865.74][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239865.75][CONN][RXD] X=3
[1479239865.76][CONN][RXD] outputs=0xf
[1479239865.78][CONN][RXD] prevValue=1.000000
[1479239865.79][CONN][RXD] ain=1.000000
[1479239865.79][CONN][RXD]
[1479239865.90][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239865.91][CONN][RXD] X=4
[1479239865.92][CONN][RXD] outputs=0x1f
[1479239865.94][CONN][RXD] prevValue=1.000000
[1479239865.95][CONN][RXD] ain=1.000000
[1479239865.95][CONN][RXD]
[1479239866.06][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239866.11][CONN][INF] found KV pair in stream: {{__testcase_finish;Analog Input on AIN_4;0;4}}, queued...
[1479239866.20][CONN][RXD] >>> 'Analog Input on AIN_4': 0 passed, 4 failed with reason 'Test Cases Failed'
[1479239866.20][CONN][RXD]
[1479239866.25][CONN][RXD] >>> Running case #6: 'Analog Input on AIN_5'...
[1479239866.29][CONN][INF] found KV pair in stream: {{__testcase_start;Analog Input on AIN_5}}, queued...
[1479239866.30][CONN][RXD] X=0
[1479239866.31][CONN][RXD] outputs=0x1
[1479239866.33][CONN][RXD] prevValue=0.000000
[1479239866.34][CONN][RXD] ain=0.000000
[1479239866.35][CONN][RXD]
[1479239866.35][CONN][RXD] X=1
[1479239866.36][CONN][RXD] outputs=0x3
[1479239866.38][CONN][RXD] prevValue=1.000000
[1479239866.40][CONN][RXD] ain=1.000000
[1479239866.40][CONN][RXD]
[1479239866.51][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239866.51][CONN][RXD] X=2
[1479239866.52][CONN][RXD] outputs=0x7
[1479239866.54][CONN][RXD] prevValue=1.000000
[1479239866.56][CONN][RXD] ain=1.000000
[1479239866.56][CONN][RXD]
[1479239866.66][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239866.67][CONN][RXD] X=3
[1479239866.68][CONN][RXD] outputs=0xf
[1479239866.70][CONN][RXD] prevValue=1.000000
[1479239866.71][CONN][RXD] ain=1.000000
[1479239866.72][CONN][RXD]
[1479239866.82][CONN][RXD] :31::FAIL: Analog Input did not increment. Check that you have assigned valid pins in mbed_app.json file
[1479239866.83][CONN][RXD] X=4
[1479239866.84][CONN][RXD] outputs=0x1f
[1479239866.87][CONN][RXD] prevValue=1.000000
[1479239866.88][CONN][RXD] ain=1.000000
[1479239866.88][CONN][RXD]

This tells me that the value being read in by the AnalogIn object is always 1.00000 or 0.00000 with no values in between, which seems to indicate an error in the underlying library.

@BlackstoneEngineering
Copy link
Contributor

FYI this is an example of a successful run on a different platform, notice how the ain values are changing

[1479240121.11][CONN][RXD] outputs=0x1
[1479240121.13][CONN][RXD] prevValue=0.001724
[1479240121.15][CONN][RXD] ain=0.196109
[1479240121.15][CONN][RXD]
[1479240121.15][CONN][RXD] X=1
[1479240121.16][CONN][RXD] outputs=0x3
[1479240121.18][CONN][RXD] prevValue=0.196246
[1479240121.20][CONN][RXD] ain=0.398764
[1479240121.20][CONN][RXD]
[1479240121.20][CONN][RXD] X=2
[1479240121.21][CONN][RXD] outputs=0x7
[1479240121.23][CONN][RXD] prevValue=0.399084
[1479240121.25][CONN][RXD] ain=0.594736
[1479240121.25][CONN][RXD]
[1479240121.25][CONN][RXD] X=3
[1479240121.27][CONN][RXD] outputs=0xf
[1479240121.29][CONN][RXD] prevValue=0.594858
[1479240121.30][CONN][RXD] ain=0.797467
[1479240121.30][CONN][RXD]
[1479240121.30][CONN][RXD] X=4
[1479240121.32][CONN][RXD] outputs=0x1f
[1479240121.34][CONN][RXD] prevValue=0.797543
[1479240121.35][CONN][RXD] ain=0.995117
[1479240121.35][CONN][RXD]

@ccli8
Copy link
Author

ccli8 commented Nov 16, 2016

Yes, NuMaker-PFM-M453 still fails. It has bug in analogin HAL. Anyway, the tests-api-analogin issue is fixed.

@ccli8 ccli8 closed this as completed Nov 16, 2016
@soramame21 soramame21 mentioned this issue Jul 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BlackstoneEngineering @ccli8